Add ReturnTypeWillChange to ReflectionEmbeddedProperty #8742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PHP CodeSniffer errors seem to be false positives. edit: Reported as slevomat/coding-standard#1233 |
|
@derrabus let's add an ignore rule with the link above then? Or is the plan to wait for an upstream fix? |
derrabus
force-pushed
the
bugfix/return-type-will-change
branch
from
0f6f28b to
6432a3e
Compare
Done. |
greg0ire
approved these changes
Jun 5, 2021
|
Thanks @derrabus ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.1 will introduce a process to add return types to internal methods, see https://wiki.php.net/rfc/internal_method_return_types
This library extends
ReflectionPropertyand overrides public methods that are affected by this change. PHP 8.1 triggers deprecation warnings unless we declare that a future version of this library will add these return types as well. We can do so by adding theReturnTypeWillChangeattribute to those methods.This PR suggests to do just that because adding the actual return types would break code that extends our classes. A future 3.0 release could add the actual return types.